dw2elf: fix compilation errors — add dwarf.h, fix AT_name_a arg count#132
Conversation
- Add #include <dwarf.h> to get DW_TAG_compile_unit, DW_TAG_subprogram, DW_TAG_formal_parameter constants (not exported via libdwarfp.h alone) - Fix all dwarf_add_AT_name_a() calls: signature requires 4 args (die, name, Dwarf_P_Attribute *outattr, Dwarf_Error *error) not 3 https://claude.ai/code/session_01WGAwvvTwDg2yknFkmZ3qzs
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates dw2elf.c to include the dwarf.h header and modifies dwarf_add_AT_name_a calls to include a mandatory Dwarf_P_Attribute parameter. Feedback was provided to ensure the return values of these calls are checked for errors to prevent incomplete DWARF generation.
| NULL, NULL, NULL, NULL, &cu_die, &err) != DW_DLV_OK) | ||
| return; | ||
| dwarf_add_AT_name_a(cu_die, (char *)srcname, &err); | ||
| dwarf_add_AT_name_a(cu_die, (char *)srcname, &attr_out, &err); |
There was a problem hiding this comment.
The return value of dwarf_add_AT_name_a is not checked. If this call fails, the compilation unit DIE will be created without a name, and the error state in err might be lost or cause issues in subsequent calls. It is recommended to check the return value for DW_DLV_OK, consistent with the error handling for dwarf_new_die_a and dwarf_add_die_to_debug_a.
if(dwarf_add_AT_name_a(cu_die, (char *)srcname, &attr_out, &err) != DW_DLV_OK)
return;| cu_die, NULL, NULL, NULL, | ||
| &func_die, &err) == DW_DLV_OK) | ||
| dwarf_add_AT_name_a(func_die, fname, &err); | ||
| dwarf_add_AT_name_a(func_die, fname, &attr_out, &err); |
There was a problem hiding this comment.
The return value of dwarf_add_AT_name_a is ignored here. If adding the function name fails, the subprogram DIE will be incomplete. Consider adding a check to handle potential errors, similar to the check for dwarf_new_die_a.
| func_die, NULL, NULL, NULL, | ||
| ¶m_die, &err) == DW_DLV_OK) | ||
| dwarf_add_AT_name_a(param_die, pname, &err); | ||
| dwarf_add_AT_name_a(param_die, pname, &attr_out, &err); |
There was a problem hiding this comment.
The return value of dwarf_add_AT_name_a is ignored for formal parameters. Checking the return value ensures that the parameter names are correctly added to the DWARF information.
2 participants
https://claude.ai/code/session_01WGAwvvTwDg2yknFkmZ3qzs